Skip to content

[Local catalog] Handle variation ids in dotcom errors #16430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshheald merged 5 commits into from
Dec 5, 2025
Merged

[Local catalog] Handle variation ids in dotcom errors #16430

joshheald merged 5 commits into from
Dec 5, 2025

Conversation

@joshheald
Copy link
Contributor

@joshheald joshheald commented Dec 3, 2025 •
edited
Loading

Description

This PR updates our handling of missing variations at POS checkout to work correctly with DotcomError as it already did with NetworkError.

DotcomError is returned when your requests are going through the WPCom tunnel, which was recently updated to return the data object in these errors.

This PR updates our DotcomError enum to make that data available, similar to how it is with NetworkError, and use it in the same way in the POSOrderService when checking out.

The PR's a bit big because I opted to make the error data available everywhere, so we can use it better in future.

Test Steps

  1. Using WPCom credentials, log in to a site with the variation IDs returned in checkout errors (e.g. woocommerce-tester.mystagingwebsite.com – there's a core change on there which isn't in core yet. Alternatively, use a jurassic ninja site with this PR deployed: Include variation_id in order item invalid variation error data woocommerce#62240)
  2. Add a variation to your POS cart
  3. In WP-Admin, delete that variation
  4. Check out
  5. Observe that the variation's name is shown in the error, and it can be removed using a button at check out (no need to go back and edit the order)

Screenshots

variation.errors.with.dotcom.error.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@joshheald
Handle variation ID in DotcomError at POS checkout
ffd81e1 
- Add `data` to `DotcomError.unknown` case
- Parse `data` and handle variation ID when present during POS checkout
- Update other uses of it to use the new signature
@joshheald
Make DotComError data available for all cases
1796b20
@joshheald joshheald added this to the 23.9 milestone Dec 3, 2025
@joshheald joshheald added type: task An internally driven task. feature: POS labels Dec 3, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 3, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16430-f5be5a3
Version23.8
Bundle IDcom.automattic.alpha.woocommerce
Commitf5be5a3
Installation URL3cirnv057hueo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma self-assigned this Dec 4, 2025
@iamgabrielma
Copy link
Contributor

iamgabrielma commented Dec 4, 2025

I'm having troubles logging into a jurassic ninja site with the PR loaded ( logged at WOOMOB-1850 ), would you mind to invite me to one of your sites where this PR is active?

@joshheald
Copy link
Contributor Author

joshheald commented Dec 4, 2025 •
edited
Loading

@iamgabrielma You already have an account on https://woocommerce-tester.mystagingwebsite.com/ which has the fix 👍

iamgabrielma
iamgabrielma approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@iamgabrielma iamgabrielma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! 🚀

@joshheald joshheald enabled auto-merge December 5, 2025 06:31
@joshheald joshheald merged commit 4a657b5 into trunk Dec 5, 2025
13 checks passed
@joshheald joshheald deleted the issue/handle-variation-ids-in-dotcom-errors branch December 5, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamgabrielma iamgabrielma iamgabrielma approved these changes

Assignees

@iamgabrielma iamgabrielma

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Milestone

23.9

Development

Successfully merging this pull request may close these issues.

4 participants

@joshheald @wpmobilebot @iamgabrielma